Support for instance image properties and authorization properties.#13
Open
kozharskyad wants to merge 3 commits intoSAP:mainfrom
Open
Support for instance image properties and authorization properties.#13kozharskyad wants to merge 3 commits intoSAP:mainfrom
kozharskyad wants to merge 3 commits intoSAP:mainfrom
Conversation
|
|
|
|
||
| {{- with .Version}} | ||
| {{- with .image }} | ||
| image: |
Contributor
There was a problem hiding this comment.
Hi,
you replaced .Version with .image but only in this section.
There is another section where version is still used.
I would suggest to replace it everywhere,
Other than that I would suggest to offer upgrade from Version to Image.
|
@kozharskyad are you planning on finishing this PR? I would need something similar. Otherwise I can make my own version in a newer PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.