refactor!: remove implicit audit logging from ObjectStore#33
Merged
ArthurTonial merged 6 commits intomainfrom Mar 31, 2026
Merged
refactor!: remove implicit audit logging from ObjectStore#33ArthurTonial merged 6 commits intomainfrom
ArthurTonial merged 6 commits intomainfrom
Conversation
jeanscherf
approved these changes
Mar 31, 2026
LucasAlvesSoares
requested changes
Mar 31, 2026
cassiofariasmachado
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR removes implicit audit logging from the ObjectStore module. Previously, all object store operations (upload, download, delete, list, etc.) automatically logged audit events.
Key Changes:
Related Issue
Closes #<issue_number>
(Link to the GitHub issue this PR addresses)
Type of Change
How to Test
uv run pytest tests/objectstore/unit/ -vChecklist
Breaking Changes
What breaks
Migration path for users
Users who need audit logging must now implement it explicitly:
Additional Notes
Files changed:
src/sap_cloud_sdk/objectstore/_s3.py- Removed audit log imports, client, helper methods, and all audit log callstests/objectstore/unit/test_s3_client.py- Removed audit client mocking from all tests