Skip to content

fix: [DevOps] Fix e2e-tests - #1049

Merged
Jonas-Isr merged 3 commits into
mainfrom
fix-e2e-tests
Sep 16, 2026
Merged

Jonas-Isr merged 3 commits into
mainfrom
fix-e2e-tests

Conversation

@Jonas-Isr

Copy link
Copy Markdown
Member

Context

Fixes current e2e test failures:

  • new models GEMINI_3_8_FLASH and GPT_51
  • change sentence used in filtering test

@Jonas-Isr Jonas-Isr self-assigned this Sep 15, 2026
@Jonas-Isr Jonas-Isr added the please-review Request to review a pull-request label Sep 15, 2026
vladimir-a-sap
vladimir-a-sap previously approved these changes Sep 15, 2026

@vladimir-a-sap vladimir-a-sap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from fix-e2e-script to main September 15, 2026 11:41
@Jonas-Isr
Jonas-Isr dismissed vladimir-a-sap’s stale review September 15, 2026 11:41

The base branch was changed.

vladimir-a-sap
vladimir-a-sap previously approved these changes Sep 15, 2026

@vladimir-a-sap vladimir-a-sap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part with models: lgtm
Part with e2e test scheduling (non blocking proposal):

  • acceptable as a temporary fix to be reverted after we stop supporting v1
  • a potentially cleaner and less brittle solution proposed in the comment here

@Jonas-Isr
Jonas-Isr enabled auto-merge (squash) September 15, 2026 11:47
@Jonas-Isr
Jonas-Isr merged commit 12cab70 into main Sep 16, 2026
7 checks passed
@Jonas-Isr
Jonas-Isr deleted the fix-e2e-tests branch September 16, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants