Skip to content

fix: [Orchestration] prompts with template references #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n-o-u-r-h-a-n wants to merge 4 commits into
base: main
Choose a base branch
from
+15 −0
Open

fix: [Orchestration] prompts with template references #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe57f7
fixing the bug
n-o-u-r-h-a-n Sep 9, 2026
183835f
Merge branch 'main' into fix-prompt-template-reference
n-o-u-r-h-a-n Sep 9, 2026
a6f39c2
Merge branch 'main' into fix-prompt-template-reference
n-o-u-r-h-a-n Sep 10, 2026
c84e11e
Merge branch 'main' into fix-prompt-template-reference
n-o-u-r-h-a-n Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions orchestration/src/main/java/com/sap/ai/sdk/orchestration/ConfigToRequestTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ static PromptTemplatingModuleConfigPrompt toTemplateModuleConfig(
* To be fixed with https://github.tools.sap/AI/llm-orchestration/issues/662
*/
if (config instanceof TemplateRef) {
if (!prompt.getMessages().isEmpty()) {
throw new IllegalArgumentException(
"Prompt must not contain messages when using a template reference");
}
return config;
}

Expand Down
11 changes: 11 additions & 0 deletions orchestration/src/test/java/com/sap/ai/sdk/orchestration/ConfigToRequestTransformerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ void testThrowsOnMissingMessages() {
.hasMessageContaining("A prompt is required");
}

@Test
void testThrowsOnTemplateRefWithMessages() {
var prompt = new OrchestrationPrompt("Foo bar");
var templateRef =
TemplateConfig.reference().byId("21cb1358-0bf1-4f43-870b-00f14d0f9f16").toLowLevel();

assertThatThrownBy(() -> ConfigToRequestTransformer.toTemplateModuleConfig(prompt, templateRef))
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("Prompt must not contain messages when using a template reference");
}

@Test
void testEmptyTemplateConfig() {
var systemMessage = new SystemMessage("foo");
Expand Down