Skip to content

Add option to not follow redirects for metadata - #449

Open
dmtaylor wants to merge 1 commit into
SAML-Toolkits:masterfrom
dmtaylor:dmtaylor/control-redirects
Open

dmtaylor wants to merge 1 commit into
SAML-Toolkits:masterfrom
dmtaylor:dmtaylor/control-redirects

Conversation

@dmtaylor

Copy link
Copy Markdown

Update get_metadata to support not following redirects from a remote source. For security reasons a caller might want to disallow fetching SSO data from a potentially untrusted source: the simplest way to ensure that the XML you're getting matches the one you want is to not allow any kind of redirecting at all. The default behavior is to follow redirects, so existing callers should be unaffected by this change. Update tests to verify that disallowing redirects don't cause a regression. Added a test mocking a 302 exception to verify the exception gets bubbled up correctly. There should probably be some kind of end-to-end test to validate this, but for now this is probably fine.

Ran black on the source & some formatting changes crept in. These are unrelated but shouldn't make a difference.

Update get_metadata to support not following redirects from a remote
source. For security reasons a caller might want to disallow fetching
SSO data from a potentially untrusted source: the simplest way to ensure
that the XML you're getting matches the one you want is to not allow any
kind of redirecting at all. The default behavior is to follow redirects,
so existing callers _should_ be unaffected by this change. Update tests
to verify that disallowing redirects don't cause a regression. Added a
test mocking a 302 exception to verify the exception gets bubbled up
correctly. There should probably be some kind of end-to-end test to
validate this, but for now this is probably fine.

Ran black on the source & some formatting changes crept in. These are
unrelated but shouldn't make a difference.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant