Repository navigation
Conversation
Update get_metadata to support not following redirects from a remote source. For security reasons a caller might want to disallow fetching SSO data from a potentially untrusted source: the simplest way to ensure that the XML you're getting matches the one you want is to not allow any kind of redirecting at all. The default behavior is to follow redirects, so existing callers _should_ be unaffected by this change. Update tests to verify that disallowing redirects don't cause a regression. Added a test mocking a 302 exception to verify the exception gets bubbled up correctly. There should probably be some kind of end-to-end test to validate this, but for now this is probably fine. Ran black on the source & some formatting changes crept in. These are unrelated but shouldn't make a difference.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update get_metadata to support not following redirects from a remote source. For security reasons a caller might want to disallow fetching SSO data from a potentially untrusted source: the simplest way to ensure that the XML you're getting matches the one you want is to not allow any kind of redirecting at all. The default behavior is to follow redirects, so existing callers should be unaffected by this change. Update tests to verify that disallowing redirects don't cause a regression. Added a test mocking a 302 exception to verify the exception gets bubbled up correctly. There should probably be some kind of end-to-end test to validate this, but for now this is probably fine.
Ran black on the source & some formatting changes crept in. These are unrelated but shouldn't make a difference.