Add tests for serde impl's Visitor::expected#213
Merged
Conversation
This is what is added to error messages when we're expecting an `Array` but some other type in a self-describing format is encountered instead. To test this we need a self-describing format, so this uses `serde_json`, and replaces `postcard` with `serde_json` for the round trip test since we can't use `postcard` to test both.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 98.38% 98.93% +0.54%
==========================================
Files 7 7
Lines 558 562 +4
==========================================
+ Hits 549 556 +7
+ Misses 9 6 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what is added to error messages when we're expecting an
Arraybut some other type in a self-describing format is encountered instead.To test this we need a self-describing format, so this uses
serde_json, and replacespostcardwithserde_jsonfor the round trip test since we can't usepostcardto test both.