Remove needless Clone bounds on Box/Vec conversions#209
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 94.60% 95.69% +1.09%
==========================================
Files 7 7
Lines 556 558 +2
==========================================
+ Hits 526 534 +8
+ Misses 30 24 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This changes the `TryFrom` impls for `Array` which convert from an owned boxed slice or `Vec` into an `Array` to not require `Clone` bounds, because we can move the owned data into the array. Also adds tests.
tarcieri
force-pushed
the
remove-clone-bounds-on-heap-types-add-tests
branch
from
e19a543 to
3443a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
TryFromimpls forArraywhich convert from an owned boxed slice orVecinto anArrayto not requireClonebounds, because we can move the owned data into the array.Also adds tests.