bignp256: migrate to LittleEndian, according to specification#1684
Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom Mar 22, 2026
Merged
bignp256: migrate to LittleEndian, according to specification#1684tarcieri merged 2 commits intoRustCrypto:masterfrom
bignp256: migrate to LittleEndian, according to specification#1684tarcieri merged 2 commits intoRustCrypto:masterfrom
Conversation
Contributor
Author
|
Also, it is blocked by RustCrypto/signatures#1109 |
tarcieri
reviewed
Mar 11, 2026
Comment on lines
89
to
+258
| @@ -247,7 +252,10 @@ where | |||
| } | |||
| ByteOrder::LittleEndian => { | |||
| let padded = self.inner.retrieve().to_le_byte_array(); | |||
| repr.copy_from_slice(&padded[..offset]); | |||
| // For little-endian encoding we expose the least-significant bytes | |||
| // at the beginning of the representation. | |||
| let len = repr.len(); | |||
| repr.copy_from_slice(&padded[..len]); | |||
Member
There was a problem hiding this comment.
It would be good if you can split these bugfix changes to primefield out into a separate PR and add a regression test
Contributor
Author
There was a problem hiding this comment.
Will do it tomorrow
Contributor
Author
|
@tarcieri i think it would be great to release it before 0.14, bcs the breaking changes |
tarcieri
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Just migrated BigEndian to LittleEndian, according to specification.
Also, there is testing methodics from Belarusian State University.
Here is the example for bign256 of signature generation:
For that, i've edited the
monty.rsfile, typed about that in #elliptic-curves > bignp256 - migrate to LE@tarcieri