Skip to content

fix(pipewire): fix 24bit sample format mapping #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpqi5858 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

fix(pipewire): fix 24bit sample format mapping #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **PipeWire**: Fix streams starting audio before `play()` is called.
- **PipeWire**: Fix rtkit burst limit errors from repeated real-time promotion on quantum jitter.
- **PipeWire**: Fix real-time promotion blocking the audio callback thread on Linux.
- **PipeWire**: Fix 24-bit sample format mapping.
- **PipeWire**: Nodes with an `/Internal` media class are now enumerated as devices.
- **PipeWire**: Streams for a specific device no longer auto-reroute if it disappears.
- **PipeWire**: Build on 32-bit targets without native 64-bit atomics.
Expand Down
8 changes: 4 additions & 4 deletions src/host/pipewire/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,13 @@ impl From<SampleFormat> for AudioFormat {
SampleFormat::U16 => Self::U16BE,

#[cfg(target_endian = "little")]
SampleFormat::I24 => Self::S24LE,
SampleFormat::I24 => Self::S24_32LE,
#[cfg(target_endian = "big")]
SampleFormat::I24 => Self::S24BE,
SampleFormat::I24 => Self::S24_32BE,
#[cfg(target_endian = "little")]
SampleFormat::U24 => Self::U24LE,
SampleFormat::U24 => Self::U24_32LE,
#[cfg(target_endian = "big")]
SampleFormat::U24 => Self::U24BE,
SampleFormat::U24 => Self::U24_32BE,
#[cfg(target_endian = "little")]
SampleFormat::I32 => Self::S32LE,
#[cfg(target_endian = "big")]
Expand Down
Loading