Skip to content

refactor(pipewire): ensure monotonic timestamps #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderickvd merged 2 commits into from
Jun 10, 2026
Merged

refactor(pipewire): ensure monotonic timestamps #1247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd634e
fix(pipewire): ensure monotonic timestamps
roderickvd Jun 9, 2026
bfccb60
fix: address review points
roderickvd Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/host/pipewire/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,12 @@ where

let (callback, capture) = match pw_stream_time(stream) {
Some(t) => {
let delay_ns = t.delay() * 1_000_000_000i64 / t.rate().denom as i64;
// `pw_stream_time` guarantees `now > 0` and `denom != 0`.
let now = t.now() as u64;
let delay_ns = (t.delay() * 1_000_000_000i64 / t.rate().denom as i64).max(0) as u64;
(
StreamInstant::from_nanos(t.now() as u64),
StreamInstant::from_nanos((t.now() - delay_ns.max(0)) as u64),
StreamInstant::from_nanos(now),
StreamInstant::from_nanos(now.saturating_sub(delay_ns)),
)
Comment thread
roderickvd marked this conversation as resolved.
}
None => {
Expand Down Expand Up @@ -343,10 +345,12 @@ where

let (callback, playback) = match pw_stream_time(stream) {
Some(t) => {
let delay_ns = t.delay() * 1_000_000_000i64 / t.rate().denom as i64;
// `pw_stream_time` guarantees `now > 0` and `denom != 0`.
let now = t.now() as u64;
let delay_ns = (t.delay() * 1_000_000_000i64 / t.rate().denom as i64).max(0) as u64;
(
StreamInstant::from_nanos(t.now() as u64),
StreamInstant::from_nanos((t.now() + delay_ns.max(0)) as u64),
StreamInstant::from_nanos(now),
StreamInstant::from_nanos(now.saturating_add(delay_ns)),
)
Comment thread
roderickvd marked this conversation as resolved.
}
None => {
Expand Down
Loading