Repository navigation
Conversation
The first click into a window that isn't key did nothing in egui-baseview. The tracking area only reports mouse moves while the window is key (ActiveInKeyWindow), and ButtonPressed carries no position, so a click into an inactive window arrived with no known cursor position and handlers that need one dropped it. mouseDown:, rightMouseDown: and otherMouseDown: now send a CursorMoved with the event's position just before ButtonPressed, the same event mouseMoved: sends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using nice-plug to write my first audio plugin, so this PR comes from a beginner.
If the GUI is out of focus, first click on buttons does nothing. After some pondering (assisted by Claude), it seems that GUI gets the click but doesn't get information about mouse position so it results in no action in plugin.
This is fixed by mouseDown:, rightMouseDown: and otherMouseDown: now send a CursorMoved with the event's position just before ButtonPressed, the same event mouseMoved: sends.
I have been using 0.3.7 and this change has been tested with it. I tried to update later baseview version, but had problems with it on my old mac which is running Monterey.