Add method for loading Chunks from RWops#1508
Open
hwright wants to merge 1 commit intoRust-SDL2:masterfrom
Open
Add method for loading Chunks from RWops#1508hwright wants to merge 1 commit intoRust-SDL2:masterfrom
Chunks from RWops#1508hwright wants to merge 1 commit intoRust-SDL2:masterfrom
Conversation
antonilol
reviewed
Nov 13, 2025
| } | ||
|
|
||
| /// Load from `RWOps` for use as a sample. | ||
| pub fn from_rwops(rwops: RWops) -> Result<Chunk, String> { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn from_rwops(rwops: RWops) -> Result<Chunk, String> { | |
| pub fn from_rwops(rwops: RWops<'_>) -> Result<Chunk, String> { |
I prefer to not hide lifetimes, just to have it clear on the function signature that RWops has a lifetime
Contributor
|
Can you also add a changelog entry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fills a hole in the existing wrapper API by calling the underlying
Mix_LoadWAV_RW.