Open
Conversation
antonilol
requested changes
Mar 19, 2025
| let include_paths: Vec<String> = if cfg!(feature = "bundled") { | ||
| vec![sdl2_includes] | ||
| } else { | ||
| compute_include_paths(sdl2_includes) |
Contributor
There was a problem hiding this comment.
This fails to compile with bindgen and bundled features enabled, so please put the call to compute_include_paths back behind #[cfg(not(feature = "bundled"))].
I get that the formatting could be better, how about this instead?
#[cfg(feature = "bundled")]
let include_paths = vec![sdl2_includes];
#[cfg(not(feature = "bundled"))]
let include_paths = compute_include_paths(sdl2_includes);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use clone when appropriate.