Make `SpirvValue`(`Kind`) representation and operations more orthogonal and robust (lossless).#348

Draft

eddyb wants to merge 23 commits intoRust-GPU:mainfrom

LykenSol:robust-spirv-value-zombies

Commits on Oct 30, 2025

Add `--dump-spirt` for dumping only the final SPIR-T module (unlike `--dump-spirt-passes`).
eddyb
committed
builder: use SPIR-V instructions for `checked_{add,sub,mul}` and `saturating_{add,sub}`.
eddyb
committed
builder: implement pointer atomics (missing in SPIR-V) via integers.
eddyb
committed
Revert "linker/inline: use `OpPhi` instead of `OpVariable` for return values."
eddyb
committed
Revert "WIP: mem2reg speedup"
eddyb
committed
Revert "WIP: couple of inliner things that need to be disentangled"
eddyb
committed
Revert "WIP: (TODO: finish bottom-up cleanups) bottom-up inlining"
eddyb
committed
Revert "linker/inline: fix `OpVariable` debuginfo collection and insertion."
eddyb
committed
[2024] linker/inline: fix `OpVariable` debuginfo collection and insertion.
eddyb
committed
[2024] linker/inline: use bottom-up inlining to minimize redundancy.
eddyb
committed
[2024] linker/mem2reg: index SPIR-V blocks by their label IDs for O(1) lookup.
eddyb
committed
[2024] linker/inline: use `OpPhi` instead of `OpVariable` for return values.
eddyb
committed
linker/inline: fix typos in comments.
eddyb
committed
[TODO(eddyb) this is probably sound but requires looping for rewrites] [2024] WIP: mem2reg unsound changes?
eddyb
committed
linker/inline: also run `remove_duplicate_debuginfo` on every fully-inlined function.
eddyb
committed
linker/inline: also run `mem2reg` on every fully-inlined function.
eddyb
committed
(placeholder)
eddyb
committed
linker/inline: don't assume `OpFunctionParameter`s are valid pointers (as it'd require outside-in inlining).
eddyb
committed
[TODO(eddyb) recursion needs this!!!] [HACK(eddyb) this works now but requires the preceding commit] linker/inline: don't rescan inlined callee blocks.
eddyb
committed
Replace `SpirvValueKind::IllegalTypeUsed` with mere `undef`.
eddyb
committed
Always register zombie messages, only at most defer their `Span`s.
eddyb
committed
Remove `SpirvValueKind::IllegalConst`.
eddyb
committed
Reduce `SpirvValue` lossiness around `strip_ptrcasts` and `const_fold_load`.
eddyb
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make `SpirvValue`(`Kind`) representation and operations more orthogonal and robust (lossless).#348

Make `SpirvValue`(`Kind`) representation and operations more orthogonal and robust (lossless).#348
eddyb wants to merge 23 commits intoRust-GPU:mainfrom
LykenSol:robust-spirv-value-zombies

Commits on Oct 30, 2025

Add `--dump-spirt` for dumping only the final SPIR-T module (unlike `--dump-spirt-passes`).

builder: use SPIR-V instructions for `checked_{add,sub,mul}` and `saturating_{add,sub}`.

builder: implement pointer atomics (missing in SPIR-V) via integers.

Revert "linker/inline: use `OpPhi` instead of `OpVariable` for return values."

Revert "WIP: mem2reg speedup"

Revert "WIP: couple of inliner things that need to be disentangled"

Revert "WIP: (TODO: finish bottom-up cleanups) bottom-up inlining"

Revert "linker/inline: fix `OpVariable` debuginfo collection and insertion."

[2024] linker/inline: fix `OpVariable` debuginfo collection and insertion.

[2024] linker/inline: use bottom-up inlining to minimize redundancy.

[2024] linker/mem2reg: index SPIR-V blocks by their label IDs for O(1) lookup.

[2024] linker/inline: use `OpPhi` instead of `OpVariable` for return values.

linker/inline: fix typos in comments.

[TODO(eddyb) this is probably sound but requires looping for rewrites] [2024] WIP: mem2reg unsound changes?

linker/inline: also run `remove_duplicate_debuginfo` on every fully-inlined function.

linker/inline: also run `mem2reg` on every fully-inlined function.

(placeholder)

linker/inline: don't assume `OpFunctionParameter`s are valid pointers (as it'd require outside-in inlining).

[TODO(eddyb) recursion needs this!!!] [HACK(eddyb) this works now but requires the preceding commit] linker/inline: don't rescan inlined callee blocks.

Replace `SpirvValueKind::IllegalTypeUsed` with mere `undef`.

Always register zombie messages, only at most defer their `Span`s.

Remove `SpirvValueKind::IllegalConst`.

Reduce `SpirvValue` lossiness around `strip_ptrcasts` and `const_fold_load`.