Panic and emit error when nvcc can't be found by which
#151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::process::Command.output() doesn't return error on non-zero exit, only when command.inner() fails. If `which nvcc` can't find `nvcc` it returns like (ExitStatus(-1), "", "") and causes a panic in the return of the function. Instead, panic on non-zero return with an informational diagnostic message.
Contributor
|
Great, thanks for the PR! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::process::Command.output() doesn't return error on non-zero exit, only when command.inner() fails.
If
which nvcccan't findnvccit returns like { ExitStatus(-1), "", "" } and causes a panic in the return of the function.Instead, we should rather panic on non-zero return with an informational diagnostic message.
Seems like this can probably be lumped into PR #143 if we'd like to stuff one PR full of build fixes.
Let me know if we'd rather not panic here and I can see about adapting things to handle the null string.