Upgrade FE dependencies#1330
Merged
Merged
Conversation
✅ Deploy Preview for antenna-preview canceled.
|
✅ Deploy Preview for antenna-ssec canceled.
|
Contributor
📝 WalkthroughWalkthroughThis PR standardizes SCSS ChangesUI Maintenance and Dependencies
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/package.json`:
- Around line 85-97: The dependency `@vitejs/plugin-react` currently at ^4.1.1
declares a peerDependency on vite ^4.2.0 which conflicts with our vite: 6;
update the `@vitejs/plugin-react` entry in package.json to a release that supports
Vite 6 (e.g., bump to a v5+ compatible semver such as ^5.0.0 or the latest
v5.x/v6-compatible tag) so the plugin's peerDependency aligns with vite: 6 and
prevents peer-dependency warnings; update package.json's "`@vitejs/plugin-react`"
value accordingly and run install to verify no peer conflicts.
In `@ui/src/components/form/layout/layout.module.scss`:
- Around line 19-20: The Stylelint rule violation is caused by missing blank
line before the declaration `color: var(--color-foreground);`; open the
`@include body-large;` and subsequent `color` declaration in the SCSS module and
insert a single empty line between `@include body-large;` and `color:
var(--color-foreground);` so the declaration-empty-line-before rule is
satisfied.
In `@ui/src/components/navigation/navigation-bar.module.scss`:
- Around line 60-64: The .itemCount rule triggers Stylelint's
declaration-empty-line-before; open the .itemCount selector and insert a blank
line after the `@include` body-xlarge; line and before the font-weight declaration
so there is an empty line between the mixin include and font-weight, keeping the
rest of the block unchanged to satisfy declaration-empty-line-before for the
.itemCount rule.
In `@ui/src/components/terms-of-service-info/terms-of-service-info.module.scss`:
- Around line 5-6: Stylelint complains about missing empty line before
declarations in the .wrapper rule; open terms-of-service-info.module.scss,
locate the .wrapper block and the `@include` body-small; mixin invocation, and
insert a single blank line immediately after the "`@include` body-small;" line so
there is an empty line before the following "padding: 8px 16px;" declaration to
satisfy the declaration-empty-line-before rule.
In `@ui/src/nova-ui-kit/components/page-header/page-header.module.scss`:
- Around line 20-21: The .title block in page-header.module.scss violates the
stylelint declaration-empty-line-before rule because the mixin call `@include`
body-large; is immediately followed by font-weight: 600; — insert a single blank
line between `@include` body-large; and font-weight: 600; (in the .title selector)
so there's an empty line before the subsequent declaration and the linter
passes.
In
`@ui/src/nova-ui-kit/components/table/basic-table-cell/basic-table-cell.module.scss`:
- Around line 6-8: In the .label rule replace the deprecated "word-break:
break-word" with the modern equivalent "overflow-wrap: anywhere" and add a
missing blank line after the "`@include` body-base;" statement; update the
selector that contains these styles (the `.label` rule in
basic-table-cell.module.scss) to use overflow-wrap: anywhere and ensure there is
an empty line after the `@include` body-base declaration so the file follows the
requested formatting.
In `@ui/src/pages/auth/auth.module.scss`:
- Around line 44-45: Add a blank line before the property declarations to
satisfy the Stylelint rule: locate the rule blocks containing the mixin call
"`@include` heading-small" followed by "color: var(--color-primary);" and the
similar block further down (the second occurrence around the 69-70 area) and
insert an empty line before each "color: ..." declaration so there is a blank
line between the preceding declaration/mixin and the color declaration.
In
`@ui/src/pages/occurrence-details/id-quick-actions/id-quick-actions.module.scss`:
- Around line 13-14: Add a blank line after each `@include` to satisfy stylelint's
declaration-empty-line-before rule: locate the SCSS blocks containing the
`@include` body-small; (and the other `@include` around lines 21-22) and insert an
empty line between the `@include` statement and the following declarations (e.g.,
before font-weight: 600) so each mixin include is followed by a blank line.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dcad608d-cee1-4ae9-a408-2c1d8e778572
⛔ Files ignored due to path filters (1)
ui/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (45)
ui/.nvmrcui/README.mdui/package.jsonui/postcss.config.cjsui/src/components/blueprint-collection/blueprint-collection.module.scssui/src/components/breadcrumbs/breadcrumbs.module.scssui/src/components/cookie-dialog/cookie-dialog.module.scssui/src/components/fetch-info/fetch-info.module.scssui/src/components/form/layout/layout.module.scssui/src/components/header/user-info-dialog/user-info-dialog.module.scssui/src/components/header/version-info/version-info.module.scssui/src/components/info-page/info-page.module.scssui/src/components/navigation/navigation-bar.module.scssui/src/components/terms-of-service-info/terms-of-service-info.module.scssui/src/nova-ui-kit/components/badge/badge.module.scssui/src/nova-ui-kit/components/card/card.module.scssui/src/nova-ui-kit/components/checkbox/checkbox.module.scssui/src/nova-ui-kit/components/combo-box/styles.module.scssui/src/nova-ui-kit/components/dialog/dialog.module.scssui/src/nova-ui-kit/components/form-stepper/form-stepper.module.scssui/src/nova-ui-kit/components/image-carousel/image-carousel.module.scssui/src/nova-ui-kit/components/info-block/info-block.module.scssui/src/nova-ui-kit/components/input/input.module.scssui/src/nova-ui-kit/components/page-header/page-header.module.scssui/src/nova-ui-kit/components/pagination-bar/info-label/info-label.module.scssui/src/nova-ui-kit/components/pagination-bar/page-button/page-button.module.scssui/src/nova-ui-kit/components/pagination-bar/pagination-bar.module.scssui/src/nova-ui-kit/components/table/basic-table-cell/basic-table-cell.module.scssui/src/nova-ui-kit/components/table/status-table-cell/status-table-cell.module.scssui/src/nova-ui-kit/components/table/table-header/table-header.module.scssui/src/nova-ui-kit/components/tabs/tabs.module.scssui/src/nova-ui-kit/components/wizard/status-bullet/status-bullet.module.scssui/src/nova-ui-kit/components/wizard/wizard.module.scssui/src/pages/algorithm-details/styles.module.scssui/src/pages/auth/auth.module.scssui/src/pages/job-details/job-stage-label/job-stage-label.module.scssui/src/pages/occurrence-details/id-quick-actions/id-quick-actions.module.scssui/src/pages/occurrence-details/status-label/status-label.module.scssui/src/pages/occurrence-details/taxonomy-info/taxonomy-info.module.scssui/src/pages/pipeline-details/styles.module.scssui/src/pages/project/entities/styles.module.scssui/src/pages/project/processing-services/processing-services.module.scssui/src/pages/project/storage/storage.module.scssui/src/pages/session-details/session-details.tsxui/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades dependencies to address security vulnerabilities and modernize the build toolchain.
Summary by CodeRabbit
Chores
Style
Documentation
Refactor