Open
Conversation
Jeremy-Walton
approved these changes
Feb 3, 2026
Member
Jeremy-Walton
left a comment
Jeremy-Walton
left a comment
There was a problem hiding this comment.
The only concern I have is that if someone is running this and doesn't know what options are available, it seems more helpful to prompt them and show what options exist
Member
Author
|
@Jeremy-Walton that's fair. I'll leave this here until we can discuss it some more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The main idea here was to make changing icon libraries easier by allowing users to just re-run the generator with a different icon library choice. I also think I like the idea of command line flags better than prompts.
What Changed
What changed in this PR?
Pre-merge checklist
lib/rolemodel_rails/version.rb