Skip to content

Add Central Model demo on SMAP data#16

Open
Shadow-AI wants to merge 101 commits into
mainfrom
demos-for-merge
Open

Add Central Model demo on SMAP data#16
Shadow-AI wants to merge 101 commits into
mainfrom
demos-for-merge

Conversation

@Shadow-AI

Copy link
Copy Markdown
Member

demos -> main

@amad-person amad-person changed the title demos-for-merge Add Central Model demo on SMAP data Oct 16, 2024
@Veggente

Copy link
Copy Markdown
Contributor

In the presentation, the anomaly detection results between Ideal and No Sharing are the following:

  Ideal No Sharing
F1 Score 0.35 0.19
TPR 25.5% 11.8%
FPR 1.5% 0.8%

Note No Sharing has lower FPR so it is not clear if Ideal is better than No Sharing at these operating points.

I wonder if the ROC or PR curves can be compared. Alternatively, we can at least show the F1 Score and TPR for the same FPR for a direct comparison.

@amad-person

Copy link
Copy Markdown
Contributor

I'm not sure if the ROC curves will be "useful" because the anomaly detection classifier is returning hard labels 🤔

How the classifier returns the hard labels:

  • 1 if current true reading of feature9 is outside a predicted range (predicted using the timeseries forecasting model)
  • 0 otherwise

@Veggente

Copy link
Copy Markdown
Contributor

I'm not sure if the ROC curves will be "useful" because the anomaly detection classifier is returning hard labels 🤔

How the classifier returns the hard labels:

* 1 if current true reading of feature9 is outside a predicted range (predicted using the timeseries forecasting model)

* 0 otherwise

There might be ways to predict soft labels or likelihoods based on the readings and the predicted ranges. Then we can use different threshold to sweep out the curves. Or there might be some parameters that directly control the tradeoff between TPR and FPR, which can be used for sweeping.

@amad-person

Copy link
Copy Markdown
Contributor

Yeah, I was thinking distance(current_reading, predicted_range_max)? Forgot to mention that the classifier returns 1 if the current reading is greater than the max of the predicted range.

@Veggente

Copy link
Copy Markdown
Contributor

Forgot to mention that the classifier returns 1 if the current reading is greater than the max of the predicted range.

Isn't that a case of "current true reading of feature9 is outside a predicted range"?

@amad-person

Copy link
Copy Markdown
Contributor

Yes that's right, we don't say the current reading is an anomaly if it is below predicted_range_min. Wanted to clarify in case this would affect how we get the soft labels 😅

@Shadow-AI Shadow-AI marked this pull request as draft October 18, 2024 16:00
@Shadow-AI Shadow-AI marked this pull request as ready for review December 4, 2024 18:13
@wolfdancer wolfdancer requested review from wolfdancer and removed request for amad-person March 13, 2026 18:54
@wolfdancer wolfdancer self-assigned this Mar 13, 2026
@wolfdancer

Copy link
Copy Markdown

We will look at Rockfish-Data/experiments#602 first as the next example, then I'll come back to this to see if we can salvage this for public consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants