Skip to content

internal/rocketclaw/web: show the session name bar on every screen size - #1538

Merged
ucirello merged 1 commit into
mainfrom
20261120-desktop-session-top-bar
Nov 20, 2026
Merged

ucirello merged 1 commit into
mainfrom
20261120-desktop-session-top-bar

Conversation

@ucirello

@ucirello ucirello commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The bar with the open session's name now shows on tablets and desktops, not just phones, and a ... button right after the title opens the menu of the tab in view, as in OpenCode. On wide screens the bar sits only above the conversation, between the tabs sidebar and any right pane, so both side panes still run the full height of the window.

The bar's menu has the same items as that tab's own ... menu in the sidebar. Rename session edits the name right in the bar. On a phone, the menu no longer needs the tab drawer opened first.

One trade-off, accepted for now: in an OpenCode session on a tablet, with the on-screen keyboard open and a long message typed, the top edge of OpenCode's message box tucks about 6px under the bar. The text stays readable. OpenCode's message box grows to a fixed height whatever space it has; making it fit is left for later. The keyboard test now checks that the box stays on screen, where before it had to stay below the top of the OpenCode area.

The tab tests check that the bar shows on wide screens and lines up with the conversation column, that its menu button sits right after the title and lists the same items as the tab's, and that renaming from the bar renames the session. Web lint and the full Web suite pass, including the browser tests that run against a real backend.

Screenshots

Desktop Tablet
Desktop: session name bar above the conversation, between the tabs sidebar and the pull requests pane Tablet: session name bar above the conversation, beside the tabs sidebar
Bar menu, desktop Bar menu, phone
Desktop: the bar's menu open under the button after the title Phone: the bar's menu open under the button after the title, without the tab drawer

Tablet, OpenCode session with the keyboard open and a long message: the top edge of the message box tucks under the bar

Taken with sample sessions. There's no before image: before this change, tablets and desktops showed no bar at all.

@ucirello
ucirello force-pushed the 20261120-desktop-session-top-bar branch 2 times, most recently from ea28364 to 38cea37 Compare November 20, 2026 19:47
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
@ucirello
ucirello force-pushed the 20261120-desktop-session-top-bar branch from 38cea37 to 7242974 Compare November 20, 2026 20:20
@ucirello
ucirello enabled auto-merge November 20, 2026 20:20
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
@ucirello
ucirello force-pushed the 20261120-desktop-session-top-bar branch from 7242974 to 7efcb26 Compare November 20, 2026 20:25
@ucirello
ucirello enabled auto-merge November 20, 2026 20:25
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
The bar naming the open session headed the page only on narrow
screens, where the tabs live in a drawer. Tablets and desktops showed
no name above the conversation.

Show it at every width. On wide screens it heads only the conversation
column, between the tabs sidebar and any right pane, which both keep
the full height. A ... button right after the title opens the menu of
the tab in view, with the same items as that tab's own menu, and
Rename session edits the name in the bar. On a phone that menu no
longer needs the drawer.

On a tablet with the keyboard open, a long draft in an OpenCode
session now tucks the top edge of OpenCode's message box under the
bar. The keyboard test now checks that the box stays on screen instead
of below the bar.

The tab browser tests check the bar on wide screens, that it lines up
with the conversation column, that its menu sits after the title and
matches the tab's, and that it renames the session.
@ucirello
ucirello force-pushed the 20261120-desktop-session-top-bar branch from 7efcb26 to f42d520 Compare November 20, 2026 20:31
@ucirello
ucirello enabled auto-merge November 20, 2026 20:31
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 818ea40 Nov 20, 2026
14 checks passed
@ucirello
ucirello deleted the 20261120-desktop-session-top-bar branch November 20, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant