Skip to content

internal/rocketclaw: move a session's pages with its page tab - #1530

Merged
ucirello merged 1 commit into
mainfrom
20261120-move-page-space
Nov 20, 2026
Merged

ucirello merged 1 commit into
mainfrom
20261120-move-page-space

Conversation

@ucirello

@ucirello ucirello commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Moving a page's tab to another space now moves the page. Before, only the tab moved. An OpenCode session's pages live in the session's space, and nothing could change that, so the link, the Pages list and who could open the pages stayed in the old space.

Now "Move to space" (or "Move group to") on a page tab moves that page's session to the new space, so all of its pages and data follow. The page tabs move with it, links name the new space, and old links redirect. Someone limited to certain spaces can only move a session into one of their spaces.

It reuses the existing session update with one new field (space_id); there is no database change. Moving the session's own chat tab still moves only your tab, and pages from a configured agent still get their space from the agent's space: setting.

A new note in docs/solutions/ explains why a page's space comes from its session (it decides who can open the page) and why moving the session beats giving pages a space of their own. CONCEPTS.md says the same under Birth Space.

Tests: a server test moves a session and checks its pages' space and the redirect from an old link; another checks that a person limited to certain spaces can't move a session into a space they don't have; a browser test moves a page tab and checks that the session's other page tab follows.

@ucirello
ucirello force-pushed the 20261120-move-page-space branch 4 times, most recently from f048af0 to 5d2a4b1 Compare November 20, 2026 19:11
@ucirello ucirello changed the title internal/rocketclaw: move a page's pages when its tab moves to another space internal/rocketclaw: move a session's pages with its page tab Nov 20, 2026
@ucirello
ucirello force-pushed the 20261120-move-page-space branch 2 times, most recently from 5c3a18d to 10d1c83 Compare November 20, 2026 19:46
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
@ucirello
ucirello force-pushed the 20261120-move-page-space branch from 10d1c83 to 07d0ed7 Compare November 20, 2026 20:11
@ucirello
ucirello enabled auto-merge November 20, 2026 20:11
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2026
Moving a Hosted Page's tab to another space only moved the tab. A remote
OpenCode session's pages live in the session's Birth Space, which nothing
could change, so their link, Page Index group and who could open them
stayed in the old space.

Move to space, and Move group, on a page tab now set the session's space
through UpdateSession, so all its pages follow. The page tabs move under
the new space's name, and old links redirect. A person with a Space
Limit can only move a session into one of their spaces.
@ucirello
ucirello force-pushed the 20261120-move-page-space branch from 07d0ed7 to cfecfd9 Compare November 20, 2026 20:22
@ucirello
ucirello enabled auto-merge November 20, 2026 20:22
@ucirello
ucirello added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit bc0659f Nov 20, 2026
14 checks passed
@ucirello
ucirello deleted the 20261120-move-page-space branch November 20, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant