Repository navigation
Conversation
DATCOM currently generates shit values. Trying to solve it. Add optional whole-vehicle native DATCOM aerodynamics, adaptive flight grids, calibration APIs and measured-flight comparison notebooks. Keep ordinary RocketPy equations unchanged. Mark predictions as experimental and unresolved. Validation: 314 relevant tests passed; both comparison notebooks executed; strict documentation build passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
Current behavior
RocketPy accepts externally supplied drag curves and provides analytical aerodynamic surface models, but cannot directly generate whole-vehicle aerodynamics using Missile DATCOM.
New behavior
Adds an opt-in integration using a user-supplied native DATCOM executable:
The executable is not distributed with RocketPy. Existing analytical equations remain unchanged.
Breaking change
Additional information
This implementation remains work in progress. DATCOM currently produces poor flight predictions for several comparison rockets, and the discrepancies are still being investigated.
Fin cross-section assumptions, particularly trailing-edge thickness, substantially affect the results. Sensitivity runs improve agreement for GENESIS and Astra, but the actual section dimensions are unavailable; these alternatives are explicitly labelled as hypotheses.
Validation includes:
Comparisons distinguish measurements, supplied drag curves and apogee-fitted CD. AST-HER has not flown; its comparison contains simulation results only. Protuberance and plume-interaction modelling are excluded.