fix: remove blocking busy-wait in handleTypingEvent (#1151)#1164
Open
Ayush-AM wants to merge 1 commit intoRocketChat:developfrom
Open
fix: remove blocking busy-wait in handleTypingEvent (#1151)#1164Ayush-AM wants to merge 1 commit intoRocketChat:developfrom
Ayush-AM wants to merge 1 commit intoRocketChat:developfrom
Conversation
Author
|
This PR addresses the critical performance issue where the UI would freeze during rapid typing events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Remove blocking busy-wait in handleTypingEvent
Acceptance Criteria fulfillment
while (typingHandlerLock) {}busy-wait loopFixes #1151
PR Test Details
The handleTypingEvent function previously used a busy-wait loop that blocked the main thread, causing the UI to freeze when multiple typing events were received.
This PR removes the locking mechanism and the
whileloop entirely. It replaces the logic with standard synchronous array operations (spliceandunshift), which are non-blocking and safe for JavaScript's single-threaded event loop. This ensures that typing indicators update smoothly without degrading UI performance.