Add libg2o#17
Open
Butakus wants to merge 2 commits into
Open
Conversation
Member
|
Thanks! |
Author
|
Build failed on osx due to missing freeglut dependency. I just added the same fix that was applied in ros-jazzy and hopefully it should pass now. BTW, I see that the win-64 CI is green. Initially I added libg2o under the "if: not win" section to replicate how it was in jazzy, but let me know if that means we can also have it on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #15, keeping all OS except Windows to replicate the jazzy setup.
I was able to build locally without needing to add any additional patch. Let me know if anything else is needed!