Repository navigation
Restore reliable local development and isolated profiles - #153
Conversation
Make the desktop app start and work locally without AWS, an Apple developer account, or an AI API key. - Isolate development data in a profile (.dev-profiles/dev or KC_PROFILE_DIR). Unpackaged runs never use per-user data. - Load the window at once. Update checks are opt-in (KC_ENABLE_UPDATES). - Give each instance its own chat server port and bearer token, passed to the renderer through IPC. Allow one instance per profile. - Replace S3 icons and examples with bundled resources. Remove dead Tika code. Resolve Resources and tiktoken paths without process.cwd(). - Stop building the unused canvas native module, which broke clean installs on Node 24. Declare fs-extra. - Fix Enter in the Web Import dialog, the favicon promise that never resolved, and loss of unreadable settings files. - Restore Settings > Backup with a versioned localStorage backup. - Skip notarization when Apple credentials are absent. - Keep the @shared path alias in kc_electron/tsconfig.json. kc_shared imports an Angular model that uses it. - Add unit tests (yarn test), Playwright end-to-end tests with fixtures (yarn e2e), and DEVELOPMENT.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RobRoyce
left a comment
RobRoyce
left a comment
There was a problem hiding this comment.
Focused integration review of PR #153 at bc66ba10041444e4f3dc72fff80c3e1ac782c69c.
No confirmed blocking finding in the combined revival stack. The independent code review checked storage writes, schema migration, managed files, backup/restore, local authentication, session recovery, Electron startup, and dependency removal. Main's conflicts were resolved without downgrading the stack's dependencies. All original commits are preserved.
Validation on the combined stack at 6ee979b2615db242ca6525bb7d0ccc36d563479f, using Node.js 24.21.0 in an isolated checkout:
- Clean immutable dependency install: passed.
- Development build and storage type check: passed.
- Unit tests: 8 passed.
- Storage tests: 35 passed.
- Hidden-window desktop tests: 4 passed.
- Headless Chrome tests: 6 passed.
- Unsigned production package and packaged workflow: passed (1 test).
Each historical intermediate branch was not rebuilt independently. Signing, live AI credentials, other operating systems, and broad dependency security auditing are outside this review.
This is a review record submitted through the PR author's account, not the independent approving review required by main's branch protection. CodeQL status is reported separately by GitHub.
1 participant
Restore startup without the deleted AWS update service and replace unavailable remote assets. Repair website entry, expose backup export, isolate development data, and give each app instance its own authenticated local server.
Depends on #152. Merge the stack in order with merge commits, retargeting each next PR to main after its predecessor lands. Do not squash or delete intermediate branches during integration.
Validation on the combined stack at
6ee979b2615db242ca6525bb7d0ccc36d563479f, using Node.js 24.21.0 in an isolated checkout:Each historical intermediate branch was not rebuilt independently. Signing, live AI credentials, other operating systems, and broad dependency security auditing are outside this review.
Focused review found no confirmed blocker in the combined stack. The review covers basic workflows, data preservation, authentication, and the dependency changes. Broader modernization remains separate work.