DEV-123965 general improvements#98
Open
tomerparizer wants to merge 8 commits into
Open
Conversation
Introduce a coding-standard and static-analysis stack for the SDK: - phpcs (PSR-12) + PHPCompatibility targeting PHP 5.5+ via phpcs.xml.dist - phpstan level 5 with a baseline for pre-existing findings - composer scripts (lint/fix/analyse/check) and a CI workflow Fix the PHP 5.5 incompatibilities the tooling surfaced in Notification.php: replace the null-coalescing operators (PHP 7.0) and provide hash_equals (PHP 5.6) via symfony/polyfill-php56, plus a self-contained fallback polyfill loaded by the bundled autoloader for non-Composer consumers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop .github/workflows/ci.yml; CI is handled elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DavidRibeiroRiskified
changed the title
|
|
||
| Migrating to API Version 2 | ||
| -------------------------- | ||
| For full API details, see the [Riskified API reference](https://apiref.riskified.com). |
Contributor
There was a problem hiding this comment.
Link is outdated, use https://developers.riskified.com
| Initialize the SDK once with your shop domain and authentication token (both available in the Riskified | ||
| web app under **Settings**), then build and submit an order. | ||
|
|
||
| ```php |
Contributor
There was a problem hiding this comment.
We can just link to the example file or have an example section that points to the sample folder no?
| * `/api/cancel` - served by `$transport->cancelOrder()` | ||
|
|
||
| Refer to the online [documentation](http://apiref.riskified.com) for more details. | ||
| Refer to the online [documentation](https://apiref.riskified.com) for more details. |
Contributor
There was a problem hiding this comment.
Update ref link
| <rule ref="Generic.PHP.ForbiddenFunctions"> | ||
| <properties> | ||
| <property name="forbiddenFunctions" type="array"> | ||
| <element key="is_null" value="null"/> |
Contributor
There was a problem hiding this comment.
| ================= | ||
| # Riskified PHP SDK | ||
|
|
||
| version: 1.12.0 |
Contributor
There was a problem hiding this comment.
Let's keep the v number in Readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
Boost the repo with more standardization