Dev 123965 general improvements fixes

phpstan.neon

@@ -1,6 +1,3 @@
-includes:
-    - phpstan-baseline.neon
-
 parameters:
     level: 5
     paths:

src/Riskified/Common/Env.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -24,4 +25,4 @@ class Env {
     const PROD = 'prod';
     const SANDBOX = 'sandbox';
     const DEV = 'development';
-}
+}

src/Riskified/Common/Exception/BaseException.php

@@ -1,4 +1,7 @@
-<?php namespace Riskified\Common\Exception;
+<?php
+
+namespace Riskified\Common\Exception;
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -14,4 +17,5 @@
  * permissions and limitations under the License.
  */
 
-class BaseException extends \Exception {}
+class BaseException extends \Exception {
+}

src/Riskified/Common/Riskified.php

@@ -1,4 +1,6 @@
-<?php namespace Riskified\Common;
+<?php
+
+namespace Riskified\Common;
 
     /**
      * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
@@ -54,19 +56,20 @@ public static function init($domain, $auth_token, $env = Env::SANDBOX, $validati
         self::$env = $env;
 
         // for backward compatibility (versions 1.0.*)
-        if (is_bool($validations))
+        if (is_bool($validations)) {
             $validations = ($validations) ? Validations::SKIP : Validations::ALL;
+        }
 
         self::$validations = $validations;
 
         // suppress timezone warnings:
         date_default_timezone_set(@date_default_timezone_get());
     }
 
-    public static function getHostByEnv(){
+    public static function getHostByEnv() {
         $env = (self::$env == null) ? Env::SANDBOX : self::$env;
 
-        switch ($env){
+        switch ($env) {
             case Env::SANDBOX:
                 return array(
                     'default' => 'sandbox.riskified.com',

src/Riskified/Common/Signature/HttpDataSignature.php

@@ -1,4 +1,5 @@
-<?php namespace Riskified\Common\Signature;
+<?php
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -14,6 +15,8 @@
  * permissions and limitations under the License.
  */
 
+namespace Riskified\Common\Signature;
+
 use Riskified\Common\Riskified;
 
 /**
@@ -23,7 +26,6 @@
  * @package Riskified\Common\Signature
  */
 class HttpDataSignature {
-
     const SHOP_DOMAIN_HEADER_NAME = 'X-RISKIFIED-SHOP-DOMAIN';
     const SUBMIT_HEADER_NAME = 'X-RISKIFIED-SUBMIT-NOW';
     const HMAC_HEADER_NAME = 'X-RISKIFIED-HMAC-SHA256';
@@ -36,5 +38,4 @@ class HttpDataSignature {
     public function calc_hmac($body) {
         return hash_hmac('sha256', $body, Riskified::$auth_token);
     }
-
-} 
+}

src/Riskified/Common/Validations.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -24,4 +25,4 @@ class Validations {
     const SKIP = 'skip';
     const IGNORE_MISSING = 'ignore_missing';
     const ALL = 'all';
-}
+}

src/Riskified/DecisionNotification/Exception/AuthorizationException.php

@@ -1,4 +1,7 @@
-<?php namespace Riskified\DecisionNotification\Exception;
+<?php
+
+namespace Riskified\DecisionNotification\Exception;
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -19,13 +22,12 @@
  * Thrown on HMAC mismatch
  * @package Riskified\DecisionNotification\Exception
  */
-class AuthorizationException extends NotificationException{
-
+class AuthorizationException extends NotificationException {
     public function __construct($headers, $body) {
         parent::__construct($headers, $body);
     }
 
     protected function customMessage() {
-        return parent::customMessage().', Authorization Error: HMAC does not match';
+        return parent::customMessage() . ', Authorization Error: HMAC does not match';
     }
-}
+}

src/Riskified/DecisionNotification/Exception/BadHeaderException.php

@@ -1,4 +1,7 @@
-<?php namespace Riskified\DecisionNotification\Exception;
+<?php
+
+namespace Riskified\DecisionNotification\Exception;
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -20,7 +23,6 @@
  * @package Riskified\DecisionNotification\Exception
  */
 class BadHeaderException extends NotificationException {
-
     protected $header;
 
     public function __construct($headers, $body, $header) {
@@ -29,7 +31,7 @@ public function __construct($headers, $body, $header) {
     }
 
     protected function customMessage() {
-        return parent::customMessage().
-        ', Header: '.$this->header;
+        return parent::customMessage() .
+        ', Header: ' . $this->header;
     }
-}
+}

src/Riskified/DecisionNotification/Exception/BadPostJsonException.php

@@ -1,4 +1,7 @@
-<?php namespace Riskified\DecisionNotification\Exception;
+<?php
+
+namespace Riskified\DecisionNotification\Exception;
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -19,4 +22,5 @@
  * Thrown on bad POST parameters in notification received
  * @package Riskified\DecisionNotification\Exception
  */
-class BadPostJsonException extends NotificationException {}
+class BadPostJsonException extends NotificationException {
+}

src/Riskified/DecisionNotification/Exception/NotificationException.php

@@ -1,4 +1,5 @@
-<?php namespace Riskified\DecisionNotification\Exception;
+<?php
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -14,6 +15,8 @@
  * permissions and limitations under the License.
  */
 
+namespace Riskified\DecisionNotification\Exception;
+
 use Riskified\Common\Exception\BaseException;
 use Riskified\Common\Signature\HttpDataSignature;
 
@@ -23,7 +26,6 @@
  * @package Riskified\DecisionNotification\Exception
  */
 class NotificationException extends BaseException {
-
     protected $headers;
     protected $body;
 
@@ -37,15 +39,13 @@ protected function headersString() {
         $headers = $this->headers;
         $hmacKey = HttpDataSignature::HMAC_HEADER_NAME;
         if (isset($headers[$hmacKey])) {
-            $headers[$hmacKey] = '***'.substr($headers[$hmacKey], -3);
+            $headers[$hmacKey] = '***' . substr($headers[$hmacKey], -3);
         }
-        return '[ '.join(', ', $headers).' ]';
+        return '[ ' . join(', ', $headers) . ' ]';
     }
 
     protected function customMessage() {
-        return 'Headers: '.$this->headersString().
-        ', Body: '.$this->body;
+        return 'Headers: ' . $this->headersString() .
+        ', Body: ' . $this->body;
     }
-
-
-}
+}

src/Riskified/DecisionNotification/Model/Notification.php

@@ -1,4 +1,5 @@
-<?php namespace Riskified\DecisionNotification\Model;
+<?php
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -19,6 +20,8 @@
  * It is a NON-best-practice to use shop URL in the notifications programmatically as this field will not be supported long term in API notifications.
  */
 
+namespace Riskified\DecisionNotification\Model;
+
 use Riskified\DecisionNotification\Exception;
 
 /**
@@ -27,7 +30,6 @@
  * @package Riskified\DecisionNotification\Model
  */
 class Notification {
-
     /**
      * @var string Order ID
      */
@@ -77,6 +79,7 @@ class Notification {
      * @param $body string The raw body of the Request
      * @throws NotificationException on issues with the request
      */
+    // @phpstan-ignore throws.notThrowable
     public function __construct($signature, $headers, $body) {
         $this->signature = $signature;
         $this->headers = $headers;
@@ -94,8 +97,9 @@ protected function test_authorization() {
         $signature = $this->signature;
         $remote_hmac = $this->headers[$signature::HMAC_HEADER_NAME];
         $local_hmac = $signature->calc_hmac($this->body);
-        if (!hash_equals($remote_hmac, $local_hmac))
+        if (!hash_equals($remote_hmac, $local_hmac)) {
             throw new Exception\AuthorizationException($this->headers, $this->body);
+        }
     }
 
     /**
@@ -104,12 +108,14 @@ protected function test_authorization() {
      */
     protected function parse_body() {
         $body = json_decode($this->body, true);
-        if (!isset($body["order"]))
+        if (!isset($body["order"])) {
             throw new Exception\BadPostJsonException($this->headers, $this->body);
+        }
 
         $order = $body["order"];
-        if (!isset($order["id"]) || !isset($order["status"]))
+        if (!isset($order["id"]) || !isset($order["status"])) {
             throw new Exception\BadPostJsonException($this->headers, $this->body);
+        }
 
         //foreach($order as $key => $value)
         //    $this->$key = $value;
@@ -120,7 +126,7 @@ protected function parse_body() {
         $this->riskIndicators = isset($order["risk_indicators"]) ? $order["risk_indicators"] : array();
         $this->description = $order["description"];
 
-        if (isset($order["category"])) { 
+        if (isset($order["category"])) {
             $this->category = $order["category"];
         }
 

src/Riskified/OrderWebhook/Exception/ClassMismatchPropertyException.php

@@ -1,4 +1,7 @@
-<?php namespace Riskified\OrderWebhook\Exception;
+<?php
+
+namespace Riskified\OrderWebhook\Exception;
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -19,4 +22,5 @@
  * thrown when wrong object assigned to field
  * @package Riskified\OrderWebhook\Exception
  */
-class ClassMismatchPropertyException extends PropertyException {}
+class ClassMismatchPropertyException extends PropertyException {
+}

src/Riskified/OrderWebhook/Exception/CurlException.php

@@ -1,4 +1,5 @@
-<?php namespace Riskified\OrderWebhook\Exception;
+<?php
+
 /**
  * Copyright 2013-2026 Riskified.com, Inc. or its affiliates. All Rights Reserved.
  *
@@ -14,11 +15,14 @@
  * permissions and limitations under the License.
  */
 
+namespace Riskified\OrderWebhook\Exception;
+
 use Riskified\Common\Exception\BaseException;
 
 /**
  * Class CurlException
  * On all cURL errors, including HTTP 500 Bad Auth
  * @package Riskified\OrderWebhook\Exception
  */
-class CurlException extends BaseException {}
+class CurlException extends BaseException {
+}