feat: Add AWS Bedrock LLM provider support with token auth#923
Merged
jaberjaber23 merged 1 commit intoRightNow-AI:mainfrom Apr 10, 2026
Conversation
|
Quick feedback from the community: |
drzow
added a commit
to drzow/openfang
that referenced
this pull request
Apr 3, 2026
Bedrock's Converse API requires exact 1:1 matching between assistant toolUse blocks and the subsequent user toolResult blocks. When message history gets messy (e.g. after session repair), mismatches cause 400 errors. This adds validate_tool_pairing() which: - Removes orphaned toolResult blocks not matching preceding assistant - Deduplicates toolResult blocks with repeated tool_use_id - Inserts synthetic error results for missing toolUse matches - Replaces empty user messages with placeholder text Inspired by RightNow-AI#923. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jaberjaber23
approved these changes
Apr 10, 2026
Member
jaberjaber23
left a comment
jaberjaber23
left a comment
There was a problem hiding this comment.
LGTM. Legitimate AWS Bedrock provider via Converse API. Well-structured 1136-line driver with proper bearer token auth (Zeroizing), complete LlmDriver trait implementation (completions, streaming, tool use, token usage), correct request/response type mappings, and clean error handling. Init wizard integration is correct. Please rebase on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds AWS Bedrock as a supported LLM provider via the Converse API using
Bedrock API Key bearer token authentication. Credentials resolve from
bedrock_api_keyin config orAWS_BEARER_TOKEN_BEDROCKenv var, withregion defaulting to
us-east-1.Changes
bedrock.rsdriver implementing the fullLlmDrivertrait (completions, streaming, tool use, token usage)bedrockregistered as a named provider increate_driver()anthropic.claude-sonnet-4-6Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity