feat(plugin): skip period re-runs for period-insensitive plugins#35
Merged
Conversation
Plugins whose panel has no `uses_period` section (e.g. RTK Gains, whose `rtk gain` data is always all-time) now keep their cached output when only the active period changes, instead of being re-spawned on every switch. The RTK plugin marks both its sections `uses_period: false`, so the existing UI logic also hides the period pills on its tab.
Rfluid
force-pushed
the
fix/plugin-period-display
branch
from
2f5d64a to
3d4b6ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins whose panel has no
uses_periodsection (e.g. RTK Gains, whosertk gaindata is always all-time) now keep their cached output whenonly the active period changes, instead of being re-spawned on every
switch. The RTK plugin marks both its sections
uses_period: false, sothe existing UI logic also hides the period pills on its tab.