ci: test window injection - #178
alfondotnet wants to merge 2 commits into
Conversation
Runs the v0.1.2 OpenURL sink (cmd /c start) on windows-latest with a GET-only callback to alfon.net?g<run_id> plus a local marker file.
Commas did not split curl.exe arguments on windows-latest, so the GET never ran. Marker still proved the & split.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Repro job can hang indefinitely
- Added 30-second context timeout to cmd.Run() and 5-minute timeout-minutes to workflow job to prevent indefinite hangs.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 818b0c8. Configure here.
| break | ||
| } | ||
| time.Sleep(200 * time.Millisecond) | ||
| } |
There was a problem hiding this comment.
Repro job can hang indefinitely
Medium Severity
The 15-second deadline only starts after cmd.Run() returns, so it never bounds the injected commands. In cmd.exe, & runs commands sequentially, and the first one is start of an https URL. If that start blocks on the runner’s browser, or if the follow-on curl hangs talking to alfon.net (no --max-time), echo and the marker check never run and the job can sit until the default runner timeout. The workflow also has no timeout-minutes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 818b0c8. Configure here.


Test plan
windows-openurl-reproon this PRPASS: local marker createdg<run_id>matching the job summaryNote
Low Risk
Adds isolated CI and a repro binary only; it does not change the CLI’s production browser-opening path.
Overview
Adds a Windows-only CI repro for the v0.1.2
OpenURLsink (exec.Command("cmd", "/c", "start", "", url)), separate from today’sShellExecuteWopener ininternal/tui.A new workflow
windows-openurl-reproruns onwindows-latestwhen the workflow orscripts/repro_windows_openurl/**changes (or viaworkflow_dispatch). It runsgo run ./scripts/repro_windows_openurl, which crafts a customer-ID-shaped URL whose&segments runechoto a local marker file andcurltohttp://alfon.net?g<GITHUB_RUN_ID>. The job fails unless both artifacts appear, provingcmd.exeparsed the injection. A follow-up step always writes the lookup URL andrun_idto the job summary for log correlation.Reviewed by Cursor Bugbot for commit 818b0c8. Bugbot is set up for automated code reviews on this repo. Configure here.