fix(output): render values as visible text in human output - #176
Draft
joshdholtz wants to merge 3 commits into
Draft
joshdholtz wants to merge 3 commits into
joshdholtz wants to merge 3 commits into
Conversation
Values coming back from the API are arbitrary text; table cells, human key/value output, browser rows and detail fields, and select option labels now drop non-printing characters before rendering. --json output is unchanged (the encoder already escapes losslessly). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- cards (rc customers show), browser breadcrumbs/error lines, chart titles, huh picker labels, cursor hints, Answer values, and the top-level error printer now go through the same helper - single-line variant for cells/labels/crumbs so values can't span rows or shift columns - JSON keeps values losslessly escaped, now including C1 codepoints, which encoding/json passes through as raw bytes - OSC 8 link URLs can no longer terminate their own sequence Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- rico plain stream deltas, chat transcript entries (the markdown renderer passes control characters through), tool/approval labels, conversation show, and error lines - --format string results decode JSON escapes back to raw bytes; keep them visible-text like every other path - rc api raw bodies get the same C1 escaping as encoded JSON - paywalls AI activity lines, chart refetch title/unit, single-option picker echo Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API values are arbitrary text. Human-mode rendering — table cells, key/value output, the interactive browser's rows/detail fields, and select option labels — now drops non-printing characters before writing to the terminal, through one shared helper.
--jsonoutput is unchanged (the encoder already escapes losslessly). Tests cover the helper and each render path.