Hunter: Use GetPointsInRadius() instead of square#1948
Draft
morganchristiansson wants to merge 3 commits into
Draft
Hunter: Use GetPointsInRadius() instead of square#1948morganchristiansson wants to merge 3 commits into
morganchristiansson wants to merge 3 commits into
Conversation
Draft
|
|
||
| void nofHunter::TryStartHunting() | ||
| { | ||
| // Find animals in a square around building (actually should be circle, but animals are moving anyway) |
Author
There was a problem hiding this comment.
Literally says it should be a circle
Flamefire
reviewed
Jun 16, 2026
Flamefire
reviewed
Jun 16, 2026
morganchristiansson
force-pushed
the
hunter-radius
branch
from
186f3a6 to
5cf72c5
Compare
morganchristiansson
force-pushed
the
hunter-radius
branch
from
5cf72c5 to
e641dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunter currently uses square, comments says it should be circle.
Update it to use new GetPointsInRadius() pattern from nofSkinner.cpp to find animals.
Also extract ANIMAL_RADIUS to shared constant used by Hunter, AI Hunter builder and Skinner.
This supports #1946 which displays building radius as outline.