Add type declarations, final classes, and modern PHP patterns#91
Merged
alganet merged 1 commit intoRespect:masterfrom Mar 15, 2026
Merged
Add type declarations, final classes, and modern PHP patterns#91alganet merged 1 commit intoRespect:masterfrom
alganet merged 1 commit intoRespect:masterfrom
Conversation
Type declarations: - Add typed properties to Db, Sql, and Mapper (PDO, Sql, Db, string, array, bool) - Add return types to all methods (static, Sql, PDOStatement, SplObjectStorage|false, void, mixed, bool, array) - Constructor typed as PDO|Db union, simplified to ternary - Fix bare return statements, replace array() with [] - Update test to expect TypeError for invalid constructor args Modern patterns: - Mark all three classes final (Db, Mapper, Sql) - Convert Db::prepare() if/elseif chain to match expression - Convert Sql::build() switch to match expression with extracted helper methods - Simplify Sql::preBuild() switch to in_array check - Remove redundant docblocks and unused imports - Add local path repository for respect/data Raise PHPStan to level 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type declarations:
Modern patterns:
Raise PHPStan to level 5.