telco_network_recovery: solver fallback handles non-OPTIMAL status#72
Draft
cafzal wants to merge 1 commit into
Draft
telco_network_recovery: solver fallback handles non-OPTIMAL status#72cafzal wants to merge 1 commit into
cafzal wants to merge 1 commit into
Conversation
The Gurobi→HiGHS fallback only caught raised exceptions. A non-OPTIMAL solve (e.g. a transient OTHER_ERROR on a cold Gurobi call) returns a termination status without raising, so the fallback never fired. Now also checks solve_info().termination_status after the solve and retries on HiGHS. Surfaced by paste-testing the same chain in the summit demo.
|
The docs preview for this pull request has been deployed to Vercel!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #71. The Gurobi→HiGHS fallback added in #71 only catches raised exceptions — but a non-OPTIMAL solve (e.g. a transient
OTHER_ERRORon a cold Gurobi call) returns a termination status without raising, so the fallback never fired and the run would fail downstream.This adds a post-solve check: if the solver was Gurobi and
solve_info().termination_status != "OPTIMAL", retry on HiGHS so the chain still produces a plan.Surfaced by paste-testing the same chain in the internal summit demo, where a cold Gurobi call returned
OTHER_ERRORand the exception-only fallback let it through.Test plan
telco_network_recovery.py— happy path: Gurobi solves OPTIMAL, no retry (unchanged behavior).