Repository navigation
Conversation
iceberg-rust's REST catalog client infers rest.auth.type=oauth2 from token/credential/oauth2-server-uri properties and logs a WARN every time it does, specifically to push callers toward setting the property explicitly instead of relying on inference. We can be that explicit caller ourselves in catalog_create_rest, so every caller (raicode included) stops getting spammed by this warning, rather than pushing the fix onto each of them individually. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iceberg-rust's REST catalog client infers
rest.auth.type=oauth2fromtoken/credential/oauth2-server-uriproperties and logs a WARN every time it does, specifically to push callers toward setting the property explicitly instead of relying on inference. We can be that explicit caller ourselves incatalog_create_rest, so every caller (raicode included) stops getting spammed by this warning, rather than pushing the fix onto each of them individually.This was originally part of #114 but got dropped in that PR's squash-merge (committed locally, never pushed to that branch before it merged) — re-submitting standalone since it's unrelated to that PR's actual content.
Test plan
make test-devsuite: 27,950 passed, 0 failed🤖 Generated with Claude Code