Conversation
…A not overwritten is not referenced
martin-frbg
reviewed
Sep 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 6122 6122
Lines 486711 486711
Branches 23268 23268
=======================================
Hits 337584 337584
Misses 148689 148689
Partials 438 438
Continue to review full report in Codecov by Harness.
|
martin-frbg
approved these changes
Sep 16, 2026
ACSimon33
requested changes
Sep 22, 2026
Comment on lines
+70
to
+74
| *> overwritten with the upper triangle of the product U * U**H, | ||
| *> and the lower triangular part of A is not referenced. | ||
| *> If UPLO = 'L', the lower triangle of A is overwritten with | ||
| *> the lower triangle of the product L**H * L, and the upper | ||
| *> triangular part of A is not referenced |
Collaborator
There was a problem hiding this comment.
Suggested change
| *> overwritten with the upper triangle of the product U * U**H, | |
| *> and the lower triangular part of A is not referenced. | |
| *> If UPLO = 'L', the lower triangle of A is overwritten with | |
| *> the lower triangle of the product L**H * L, and the upper | |
| *> triangular part of A is not referenced | |
| *> overwritten with the upper triangle of the product U * U**H, | |
| *> and the strictly lower triangular part of A is not | |
| *> referenced. If UPLO = 'L', the lower triangle of A is | |
| *> overwritten with the lower triangle of the product L**H * L, | |
| *> and the strictly upper triangular part of A is not | |
| *> referenced. |
I'd suggest saying that the strictly uppler/lower triangular parts are not referenced to avoid confusion. Also add a full stop at the end.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the documentation of LAUUM routines to state the unused strictly triangular component is not referenced
Closes #1415
Checklist