Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 6122 6122
Lines 486711 486759 +48
Branches 23268 23268
=======================================
+ Hits 337584 337640 +56
+ Misses 148689 148681 -8
Partials 438 438
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds one check per tester at the end of
CHECK2, with the scalar set to zero:?axpymust leave Y bit-for-bit untouched, and?axpbymust returnbeta*Y.betais 0.5 in the real testers and(0.7,-0.4)in the complex ones, so for the real case the expected result is exact andSTESTcompares against it directly.Coverage
Measured locally with gfortran 13.3.0:
BLAS/SRCbuilt-O0 -g --coverage -fno-inline, the four?blat1drivers linked against it and run, thengcov -b -n. Percentages are lines executed and branches taken at least once; the denominators are gcov's.saxpy.f,daxpy.fcaxpy.f,zaxpy.fsaxpby.f,daxpby.f,caxpby.f,zaxpby.fThe two branches still untaken in
saxpy/daxpyafter this are the back edges of the 4-way unrolled loop, which only repeats atN >= 8; the testers stop atN = 4. That is a separate gap, addressed in #1413.