fix(hermes): i18n, plugin-delete, mascot animation + README follow-ups#79
Merged
Conversation
The Hermes skill category picker showed hardcoded English (Choose a Hermes category / Install to Hermes / + New / placeholder / Cancel) even in Chinese locale. Route them through the common namespace (hermesCategory.* plus the existing common.cancel), wired in the shared picker, the detail panel, and the marketplace page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
delete_extension's plugin branch let Hermes fall into the generic fallback, which only removed the plugin directory. Deleting an enabled Hermes plugin left a stale entry in config.yaml plugins.enabled (and a re-install of the same name would then be unexpectedly auto-enabled). Add a dedicated hermes arm that removes the directory AND drops the name from plugins.enabled, mirroring how codex/gemini clean both the folder and the config entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The icon is a classical left-facing profile (a coin/cameo head), so the motion leans into that instead of the generic float+spin: - hover: a soft specular band sweeps diagonally across the profile, clipped to the silhouette so it never bleeds onto the card. Colour is theme-aware via --hermes-gleam: a white glint on the dark light-theme silhouette, a pale warm gold on the white dark-theme silhouette. - click: the whole face flips like a tossed coin (perspective rotateY 720° with a small lift at the apex). Reduced-motion is already covered by the existing .mascot-hermes wildcards. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Update both media assets (referenced by README.md and README.zh-CN.md) to the latest UI, which now includes Hermes among the agents. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
RealZST
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups on top of the merged Hermes agent support (#74), all scoped to Hermes/UX polish.
Changes
react-i18next(common.hermesCategory.*) with en + zh.plugins.enabledwhen deleting a plugin — deleting a Hermes plugin previously fell into the generic remove-folder path, leaving a stale entry inconfig.yamlplugins.enabled(so a re-install of the same name would auto-enable). Now removes both the directory and the config entry, mirroring codex/gemini. Covered by a unit test.rotateY). Reduced-motion covered by the existing wildcards.media/overview.pngandmedia/agents-animation.gif(referenced by both README.md and README.zh-CN.md) to the current UI, which now includes Hermes.Testing
~/.hermes(deleting an enabled plugin cleansplugins.enabled; deleting a disabled one correctly leaves it untouched).🤖 Generated with Claude Code