fix(restore): surface a retryable error instead of an endless spinner#681
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
Conversation
restoreWallet() had no try/catch: a persist/crypto failure escaped as an unhandled async error, the cubit stayed in isLoading and — because the button renders .loading whenever wallet==null — the user was stranded on a permanent spinner with no way out. End-to-end fix across both layers: - cubit: try/catch + isClosed guard, emits a terminal RestoreWalletState (hasError: true) and logs the failure - state: new hasError flag (in props) - button: on hasError renders a tappable "Restore failed – tap to retry" (idle + refresh icon; the error-state button is non-interactive) that re-invokes restoreWallet with the entered seed - l10n: new restoreWalletFailed string (EN/DE) Regressions: restore_wallet_cubit_test.dart (error state + retry recovery), restore_wallet_page_test.dart (tappable retry, no spinner). Issue RealUnitCH#657 — Part 1, finding B1 (HIGH).
joshuakrueger-dfx
force-pushed
the
joshua/fix-657-p1b1-restore-error
branch
from
f1fdeed to
bf8255f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #657 — Part 1, finding B1 (HIGH).
Problem
restoreWallet()had no try/catch — a persist/crypto failure escaped as an unhandled async error and the cubit stayedisLoading. The button renders.loadingwheneverwallet == null, so the user was stranded on a permanent spinner with no retry.Fix (beide Layer — Big-Brother-Design-Skeptic hatte einen Cubit-only-Fix als unvollständig geblockt)
isClosedguard → terminalerhasError-State + LoghasError-Flag (in props)hasErrorein tappbarer "Restore failed – tap to retry" (idle + Refresh-Icon; der error-State-Button ist nicht interaktiv), derrestoreWalletmit dem eingegebenen Seed erneut aufruftrestoreWalletFailed-String (EN/DE)Tests (RED→GREEN, proven)
Cubit: Error-State statt Endlos-Loading + Retry-Recovery (failt am alten Code, verifiziert). Widget: Retry tappbar, kein Spinner. Suite 30/30 grün, analyze clean.
🤖 Big Brother fleet analysis (Design-Skeptic scope verdict) + operator hand-finish. Ref #657.