fix(dashboard): guard pending-transactions emits against post-close StateError#678
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
Conversation
…tateError
PendingTransactionsCubit fires an un-awaited fetch from its constructor and
emits the result (or [] on error) with no isClosed guard. If the cubit is
closed (page popped) before the fetch resolves, emit throws
'Cannot emit new states after calling close' — and the catch's emit([]) throws
again, uncaught. Guard both emits with isClosed.
Regression: test/screens/dashboard/pending_transactions_cubit_test.dart
("does not emit if closed before the fetch resolves")
Issue RealUnitCH#657 — Part 3, finding RealUnitCH#16.
joshuakrueger-dfx
force-pushed
the
joshua/fix-657-p3-16-pending-isclosed
branch
from
76d6659 to
8e95352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #657 — Part 3, finding #16.
PendingTransactionsCubitfires an un-awaited fetch from its constructor and emits the result (or[]on error) with noisClosedguard. If the cubit is closed (page popped) before the fetch resolves,emitthrows Cannot emit new states after calling close — and the catch'semit([])throws again, uncaught. Both emits are now guarded. New RED→GREEN regression (proven), suite 4/4 green, analyze clean.🤖 Fleet-confirmed defect, hand-finished by operator. Ref #657.