fix(sell): handle sell-balance stream errors instead of silently stopping#676
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
Conversation
…ping SellBalanceCubit subscribed with watchBalance(...).listen(emit) and no onError, so a stream error escaped as an unhandled async error and the sell balance silently stopped updating. Add an onError handler that logs the failure; with cancelOnError defaulting to false the subscription stays alive so later balances still update. Regression: test/screens/sell/cubits/sell_balance_cubit_test.dart Issue RealUnitCH#657 — Part 4, finding S6.
joshuakrueger-dfx
force-pushed
the
joshua/fix-657-p4s6-sellbalance-onerror
branch
from
7a621d2 to
987cc1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #657 — Part 4, finding S6.
SellBalanceCubitusedwatchBalance(...).listen(emit)with noonError— a stream error escaped as an unhandled async error and the sell balance silently stopped. Adds anonErrorhandler (logs;cancelOnErrorfalse keeps the subscription alive). New RED→GREEN regression (proven), suite 5/5 green, analyze clean.🤖 Fleet-confirmed defect (Design-Skeptic PASS), hand-finished by operator. Ref #657.