fix(receive): guard wallet-address rendering against RangeError on short input#673
Open
joshuakrueger-dfx wants to merge 1 commit into
Open
Conversation
…ort input
QRAddressWidget sliced the address with fixed indices (substring 0,6 / 6,21
/ 21,36 / 36), which threw a RangeError for any address shorter than 36
characters — crashing both the Receive screen and Settings → Wallet address.
Replace the raw slices with a length-clamping helper: a full 0x-address still
groups into the same chunks, while a short or empty address renders
gracefully instead of crashing.
Regression: test/screens/receive/widgets/qr_address_widget_test.dart
("renders a short/unexpected address without a RangeError")
Issue RealUnitCH#657 — Part 6, finding F1 (HIGH, crash).
joshuakrueger-dfx
force-pushed
the
joshua/fix-657-p6-qr-substring
branch
from
d6fb835 to
1f9e794
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #657 — Part 6, finding F1 (HIGH, crash).
Problem
QRAddressWidgetsliced the address with fixed indices (substring(0,6)/(6,21)/(21,36)/(36)). Any address shorter than 36 chars → RangeError crash on both Receive and Settings → Wallet address.Fix
Replace the raw slices with a length-clamping
_slicehelper. A full 0x-address groups into the identical chunks as before; a short or empty address renders gracefully.Tests (RED→GREEN, proven)
New widget regression: short address
0x1234and empty address both render withtakeException() == null— fails on the old code (verified), passes with the fix. Suite green (5/5),flutter analyzeclean.🤖 Big Brother fleet flagged + hand-finished at the operator test-authorization boundary. Ref #657.