fix(kyc): MergeProcessing follow-ups — golden test, coverage, refresh-timeout guard#655
Open
joshuakrueger-dfx wants to merge 2 commits into
Open
fix(kyc): MergeProcessing follow-ups — golden test, coverage, refresh-timeout guard#655joshuakrueger-dfx wants to merge 2 commits into
joshuakrueger-dfx wants to merge 2 commits into
Conversation
…golden test - checkKyc() captures the pre-run state: a watchdog timeout during a refresh from KycMergeProcessing re-emits KycMergeProcessing instead of KycFailure, so a slow merge no longer routes the user to the error screen (#654 item 4) - new fakeAsync unit test covers the guard (keeps the cubit coverage floor) - new golden test for KycMergeProcessingPage with pumpOnce (endless spinner never settles); macOS baseline to be generated on dfx01 (#654 items 1+3) - handbook mapping intentionally omitted, matching kyc_account_merge and the other transient KYC states (#654 item 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654
Changes
Item 1+3 — Golden test for
KycMergeProcessingPagetest/goldens/screens/kyc/kyc_merge_processing_golden_test.dart, modeled onkyc_account_merge_golden_test.dart; usespumpBeforeTest: pumpOncebecause the page shows aCupertinoActivityIndicator(endless animation never settles).golden-regenerate.yaml(commit on this branch).Item 4 — Refresh-timeout guard
KycCubit.checkKyc()captures the pre-run state (before_runCheckKycreplaces it withKycLoading). If the 30s watchdog fires on a refresh that started fromKycMergeProcessing, the cubit re-emitsKycMergeProcessinginstead ofKycFailure— the user stays on the waiting screen instead of being routed to the error screen.KycFailure) is untouched and still proves the guard is narrowly scoped.KycFailure(intentional).Item 2 — Handbook mapping: intentionally omitted
kyc_account_merge,kyc_loading,kyc_pending,kyc_failureand the other transient KYC states are deliberately not in the handbook; this avoids bumping the hard-coded screenshot count in the Handbook Build Check for a short-lived spinner state.Verification
flutter test test/screens/kyc/cubits/kyc/kyc_cubit_test.dart— 36/36 green (incl. new test)