Skip to content

Fix simple compiler warnings - #1118

Open
anf3is wants to merge 12 commits into
ReactiveDrop:reactivedrop_betafrom
anf3is:rf/fix-compiler-warnings3
Open

Fix simple compiler warnings#1118
anf3is wants to merge 12 commits into
ReactiveDrop:reactivedrop_betafrom
anf3is:rf/fix-compiler-warnings3

Conversation

@anf3is

@anf3is anf3is commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Mostly fixed trivial overshadowing

  • reuse buffers with same names that can be reused
  • remove some redundant getters
  • outcommented some code because it looks like it should be let there as a 'todo' remainder.
  • fix warnings about expressions in if and while condition
  • suppress warning about unused variables that were used only in debug code
  • specify template

Fix:

  • replace double HUGE_VAL with float FLT_MAX
  • ensure correct << operator precedence

@anf3is
anf3is marked this pull request as draft September 28, 2026 23:51
@anf3is
anf3is force-pushed the rf/fix-compiler-warnings3 branch from 2001c1e to ebdfad3 Compare September 29, 2026 11:25
@anf3is anf3is changed the title Fix last compiler warnings Fix simple compiler warnings Sep 29, 2026
@anf3is
anf3is marked this pull request as ready for review September 29, 2026 11:31
anf3is added 10 commits September 29, 2026 13:39
@anf3is
style: fix misleading indentation warning
fc95aaf
@anf3is
suppress C4198 for variables used in assert
53c9317
@anf3is
refactor: move assignment used as a condition from if
3ba7110
@anf3is
refactor: move pInflictor into if condition
7125e27
@anf3is
refactor: assignment in while condition
9e9c72b
@anf3is
refactor: rename variables to prevent shadowing
0b0770e 
rename matching members and method parameters in tokenset
rename pos -> col
rename sz -> current
rename wzValue -> wzTime
rename item -> definition
rename vecForward -> vecRandForward
unshadow start end
rename first pszExpression -> pszFlexExpression
rename buffer -> snumber
rename pMarine -> pOwningMarine
add y_last
lazy rename flags -> iFlags
rename fadeFraction -> outFadeFraction
rename vecCenter -> vecCenterDbg
@anf3is
refactor: remove unused and redundand variables
0529876 
remove second shadow getter
remove unresolved extern convar
remove additional save getterr
remove unused buffer
outcomment unused variables
remove redefinition of ALIGN_VALUE
@anf3is
fix!: remove second controller getter
699e3cb
@anf3is
fix C4864: specify template
3ed605d
@anf3is
fix!: use huge val with correct type
fec89b1 
prevent C4756: overflow
@anf3is
anf3is force-pushed the rf/fix-compiler-warnings3 branch from ebdfad3 to fec89b1 Compare September 29, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@anf3is