Skip to content

fix: allow @floating-ui/dom 1.7.6 and above - #1291

Merged
danielbarion merged 1 commit into
masterfrom
fix/floating-ui-dom-range
Nov 9, 2026
Merged

danielbarion merged 1 commit into
masterfrom
fix/floating-ui-dom-range

Conversation

@danielbarion

@danielbarion danielbarion commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes #1290.

@floating-ui/dom was pinned to 1.7.6. @floating-ui/react-dom requires ^1.8.0, so an app that uses both installed two copies. The dependency is now ^1.7.6 (>=1.7.6 <2.0.0), which overlaps ^1.8.0, so npm can hoist one 1.8.x.

This repo still resolves 1.7.6. v6 only calls computePosition, offset, shift, flip, arrow, and autoUpdate. Those calls passed the positioning tests against 1.8.0, and 1.8.0 does not change them.

Test plan

  • Positioning tests passed with @floating-ui/dom@1.8.0 installed
  • An app that depends on both react-tooltip and @floating-ui/react has a single @floating-ui/dom after install

Summary by CodeRabbit

  • Chores
    • Updated a supporting package’s accepted version range to include compatible releases. No user-facing behavior changes are included in this update.

An exact 1.7.6 cannot be deduped with @floating-ui/react-dom, which
requires ^1.8.0. A caret range lets an app keep one copy.

Fixes #1290
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The @floating-ui/dom dependency declaration changes from the exact version 1.7.6 to the compatible range ^1.7.6.

Changes: Dependency range

Layer / File(s) Summary
Update dependency range
package.json
The @floating-ui/dom dependency now uses ^1.7.6 instead of the exact version 1.7.6.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested labels: Bug

Merge Risk: Minimal · up to cafce

The dependency range permits sharing a compatible installation. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the dependency range change. The range excludes version 2.0.0 and above.
Linked Issues check Passed [#1290] package.json changes @floating-ui/dom from 1.7.6 to ^1.7.6. This range overlaps @floating-ui/react-dom's ^1.8.0 range and permits npm to hoist one compatible copy. The PR reports t…
Out of Scope Changes check Passed [#1290] The reviewed change to package.json directly supports the requested dependency range. No reviewed change is unrelated to the issue.
Full details: Linked Issues check

Explanation

[#1290] package.json changes @floating-ui/dom from 1.7.6 to ^1.7.6. This range overlaps @floating-ui/react-dom's ^1.8.0 range and permits npm to hoist one compatible copy. The PR reports that positioning tests passed with 1.8.0. The combined-app installation test remains unchecked, but the issue does not require that test.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Oops! Something went wrong! :(

ESLint: 10.2.0

TypeError [ERR_IMPORT_ATTRIBUTE_MISSING]: Module "file:///.eslintrc.json?mtime=1794056383873" needs an import attribute of "type: json"
at validateAttributes (node:internal/modules/esm/assert:110:15)
at defaultLoadSync (node:internal/modules/esm/load:163:3)
at #loadAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:806:12)
at #loadSync (node:internal/modules/esm/loader:838:53)
at ModuleLoader.load (node:internal/modules/esm/loader:787:26)
at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:498:31)
at #getOrCreateModuleJobAfterResolve (node:internal/modules/esm/loader:564:36)
at afterResolve (node:internal/modules/esm/loader:611:52)
at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:617:12)
at node:internal/modules/esm/loader:636:32

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e7f85607-c59d-494e-904d-0a0193d7cc33
Commits

Reviewing files that changed from the base of the PR and between 60b9d31 and cafce20.

Files ignored due to path filters: 1

  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

Beta version released with the last commit 🚀

yarn add react-tooltip@6.0.9-beta.1291.rc.0

or

npm install react-tooltip@6.0.9-beta.1291.rc.0

@danielbarion
danielbarion merged commit 57f5e24 into master Nov 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT REQ] Allow a range for @floating-ui/dom instead of pinning 1.7.6

1 participant