Deduce arena grain size in MMQA test function/136.c.#88
Open
gareth-rees wants to merge 3 commits into59-memory-awarefrom
Open
Deduce arena grain size in MMQA test function/136.c.#88gareth-rees wants to merge 3 commits into59-memory-awarefrom
gareth-rees wants to merge 3 commits into59-memory-awarefrom
Conversation
On Apple Silicon, when Hardened Runtime is in force and the application lacks the "Allow Unsigned Executable Memory Entitlement", mmap and mprotect return EACCES when an attempt is made to create or modify memory so that it is simultaneously writable and executable. This commit handles these cases by retrying the operation without the PROT_EXEC flag, and setting global variables so that future operations omit the flag.
* Use memory-model-aware builtins in GCC and Clang when a memory location may be written by one thread and read by another, avoiding race conditions due to out-of-order updates on ARM. * Call dylan_make_wrappers while the test is still single-threaded, preventing multiple threads from racing to call it. * Prevent dylan_init from creating a padding object, as we must not have an exact root pointing at a padding object.
This makes the test portable to XCA6LL, where the page size (and so the minimum arena grain size) can be 16 kB.
gareth-rees
force-pushed
the
59-memory-aware
branch
from
b71e18c to
e089937
Compare
thejayps
added
the
optional
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the test portable to XCA6LL, where the page size (and so the minimum arena grain size) can be 16 kB.
This fixes one of the test failures in #84.