Skip to content

Only show scroll bars for students instructions when needed #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DNR500 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only show scroll bars for students instructions when needed #1613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/assets/stylesheets/Instructions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
@use "./scratch_colours" as *;

.project-instructions {
block-size: 100%;
// Student preview sizes to its content so short steps are not scrollable.
&:has(.c-instruction-tabs) {
block-size: 100%;
}
Comment on lines +9 to +12

@maxelkins maxelkins Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I assume in the react component we already know when this tab is rendered - we could use a modifer class instead for slightly better browser support. Although :has() is baseline now 🤷


@each $block, $category in $scratch-block-categories {
code.block3#{$block} {
Expand Down
Loading