Skip to content

Change order of operations in persist_changes #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamiebenstead wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Change order of operations in persist_changes #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/concepts/project/operations/update.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ def persist_changes(response)
return if response.failure?

ActiveRecord::Base.transaction do
response[:project].save!
response[:project].components.where(id: response[:component_ids_to_delete]).destroy_all
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because update_component_attributes enumerates response[:project].components, the association is loaded before persist_changes. Calling components.where(...).destroy_all may not reliably remove those destroyed records from the already-loaded association cache, so project.save! can still validate the destroyed components and fail (potentially keeping the Sentry error). Prefer deleting via the association proxy (e.g., response[:project].components.destroy(response[:component_ids_to_delete])) or otherwise ensuring the in-memory collection no longer contains the records being deleted before save! runs validations.

Suggested change
response[:project].components.where(id: response[:component_ids_to_delete]).destroy_all
response[:project].components.destroy(response[:component_ids_to_delete])

Copilot uses AI. Check for mistakes.
response[:project].save!
end
end
end
Expand Down
Loading