Repository navigation
Configure timeouts on HTTP requests - #1062
Open
zetter-rpf wants to merge 1 commit into
Open
zetter-rpf wants to merge 1 commit into
zetter-rpf wants to merge 1 commit into
Conversation
We don't currently have timeout configured, which means they are quite large (30-60 seconds) and can exhaust dynos. Configure timeouts. These are quite generous - I would expect 1s should be enough for most requests, but we don't have good visibility on this for the moment. I've chosen to start with 5/10 seconds and then we can always ratchet this down further in the future. The timeouts are documented in: https://redirect.github.com/lostisland/faraday/blob/main/lib/faraday/options/request_options.rb#L16-L29
zetter-rpf
marked this pull request as ready for review
October 16, 2026 08:10
Test coverage94.11% line coverage reported by SimpleCov. |
zetter-rpf
changed the title
adrian-rpf
approved these changes
Oct 16, 2026
adrian-rpf
left a comment
adrian-rpf
left a comment
Contributor
There was a problem hiding this comment.
Good limits set, we should monitor numbers over the first week once this is deployed.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
We don't currently have timeout configured, which means they are quite large (30-60 seconds) and can exhaust dynos.
Configure timeouts. These are quite generous - I would expect 1s should be enough for most requests, but we don't have good visibility on this for the moment. I've chosen to start with 5/10 seconds and then we can always ratchet this down further in the future.
The timeouts are documented in:
https://redirect.github.com/lostisland/faraday/blob/main/lib/faraday/options/request_options.rb#L16-L29