chore: degulpify the package tasks - #10323
Open
maribethb wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10300
Proposed Changes
gulpfiles/package_tasks.jsand replaces it with a function-by-function equivalent that uses plain node scripts instead of gulp tasks.gulpfiles/helper_tasks.jsand replaces it with several different utility files with better-organized helper functions.replaceon the contents of all the msg files to "remove references to goog.module and goog.provide" -- there weren't any of those references present, and that is a bug waiting to happen if a translation ever contains the stringgoogThe biggest addition in this PR is
scripts/package.mjsand if you review that side-by-side with the old (deleted in this PR)gulpfiles/package_tasks.jsit's easier to understand since it really is function-by-function equivalent (with the exception above about the msg files)Reason for Changes
This is faster and easier to read
Test Coverage
Verified that the results of
dist/are identical before and after this change.Documentation
n/a
Additional Information
This change was created with assistance from Claude and manually verified / tested / rewritten where needed