feat: accessibility, reduce motion, CI cache, and Line detection#7
Draft
RamboWasReal wants to merge 2 commits into
Draft
feat: accessibility, reduce motion, CI cache, and Line detection#7RamboWasReal wants to merge 2 commits into
RamboWasReal wants to merge 2 commits into
Conversation
- Add CocoaPods cache step to iOS CI job - Set accessibilityState.busy while loading - Respect Reduce Motion with a static baseColor skeleton - Detect GleamView.Line inside wrapper Views on first render - Warn in DEV when loading is omitted but children are present - Upgrade prettier to v3 and add tests for new behavior Co-authored-by: David Boutin <RamboWasReal@users.noreply.github.com>
- Add Reduce Motion status banner driven by AccessibilityInfo - Add wrapped GleamView.Line section with accessibility labels - Document example app demos in README Co-authored-by: David Boutin <RamboWasReal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the improvements identified during the codebase audit on branch
cursor/improvements-audit-6a43.Pods,~/.cocoapods,vendor/bundle) so the existing cache-hit condition worksaccessibilityState.busyautomatically whileloading={true}(merged with any existing state)baseColorskeleton instead of the native shimmer animation (GleamViewandGleamView.Line)<View>) so Lines are detected on the first render — stable ref, no NativeGleamView→View fliploadingis omitted butchildrenare present (defaults totrue)prettierto v3Test plan
yarn test— 97 tests passyarn typecheckyarn lintyarn prepare(bob build)Not included (future work)
borderRadiuson shimmer overlay (native change)